MAYA-104936 instanceIndices may contain duplicate indices. #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamkrick
commented
Jun 9, 2020
kxl-adsk
approved these changes
Jun 9, 2020
|
@cfmoore007 This is some defensive code that "fixes" the issue you reported with drawing instanced selection. I'm not sure this is the code we'll check in, but this change does give what I believe will be the final performance, if you are interested in testing. |
huidong-chen
suggested changes
Jun 9, 2020
|
I re-tested this with usd dev branch @ e7ff8e85 rather than 20.05 that we use internally normally, and the issue with the N^2 instances is fixed in that version, so this change doesn't provide a speedup with newer builds of USD. I will protect this defensive code so that it only runs for USD versions 20.05 and older. @cfmoore007 The issue you are seeing is something else, I will keep investigating. |
|
Thanks, @williamkrick |
williamkrick
force-pushed
the
krickw/MAYA-104936/dont_draw_selected_instances_multiple_times
branch
from
9ee858e to
71451e2
Compare
williamkrick
force-pushed
the
krickw/MAYA-104936/dont_draw_selected_instances_multiple_times
branch
from
71451e2 to
a4074ea
Compare
kxl-adsk
reviewed
Jun 10, 2020
kxl-adsk
approved these changes
Jun 10, 2020
huidong-chen
approved these changes
Jun 10, 2020
kxl-adsk
deleted the
krickw/MAYA-104936/dont_draw_selected_instances_multiple_times
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only add each instance transform at most once.